[Lldb-commits] [lldb] 473a3a7 - Disable check_qmemtags unit tests

Muhammad Omair Javaid via lldb-commits lldb-commits at lists.llvm.org
Thu Jun 24 15:36:42 PDT 2021


Author: Muhammad Omair Javaid
Date: 2021-06-24T22:36:31Z
New Revision: 473a3a773ea565612e836ae6c2093178c5a9eb72

URL: https://github.com/llvm/llvm-project/commit/473a3a773ea565612e836ae6c2093178c5a9eb72
DIFF: https://github.com/llvm/llvm-project/commit/473a3a773ea565612e836ae6c2093178c5a9eb72.diff

LOG: Disable check_qmemtags unit tests

check_qmemtags tests are broken on Arm 32 bits. This patch disables
these tests.

Differential Revision: https://reviews.llvm.org/D95602

Added: 
    

Modified: 
    lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp b/lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp
index b9fc107527a21..91e63451d949c 100644
--- a/lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp
+++ b/lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp
@@ -465,7 +465,7 @@ TEST_F(GDBRemoteCommunicationClientTest, GetQOffsets) {
   EXPECT_EQ(llvm::None, GetQOffsets("TextSeg=0x1234"));
   EXPECT_EQ(llvm::None, GetQOffsets("TextSeg=12345678123456789"));
 }
-
+#if 0
 static void
 check_qmemtags(TestClient &client, MockServer &server, size_t read_len,
                const char *packet, llvm::StringRef response,
@@ -530,3 +530,4 @@ TEST_F(GDBRemoteCommunicationClientTest, ReadMemoryTags) {
   check_qmemtags(client, server, 32, "qMemTags:def0,20:1", "m01020",
                  llvm::None);
 }
+#endif


        


More information about the lldb-commits mailing list