[Lldb-commits] [PATCH] D104856: [lldb] replace gethostbyname call by getaddrinfo

Thu Jun 24 11:55:15 PDT 2021

teemperor added a comment.

In D104856#2839256 <https://reviews.llvm.org/D104856#2839256>, @jankratochvil wrote:

> On OSX with `-DLLDB_USE_SYSTEM_DEBUGSERVER=OFF` I have built:
> -rwxr-xr-x  1 macbook  staff  689200 Jun 24 19:10 bin/debugserver
> It uses `lldb/tools/debugserver/source/RNBSocket.cpp` (if I mess up the source file it does not build). The build does not need this `ResolveIPV4HostName` function.
> So unless there is some more OSX magic the function can be removed.

Sorry, I thought you meant with "this function" `gethostbyname` not `ResolveIPV4HostName`. You're right, this is indeed unused and it's also used in our downstream repo I think, so let's get rid of it. Good catch!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104856/new/

https://reviews.llvm.org/D104856