[Lldb-commits] [PATCH] D104856: [lldb] replace gethostbyname call by getaddrinfo

[Raphael Isemann via Phabricator via lldb-commits]

teemperor added a comment.

In D104856#2838600 <https://reviews.llvm.org/D104856#2838600>, @jankratochvil wrote:

> In D104856#2838571 <https://reviews.llvm.org/D104856#2838571>, @teemperor wrote:
>
>> The file is part of `debugserver` which is Darwin exclusive and is also only compiled/used when you're on Darwin. It's also kind of its own thing: it isn't using LLVM libraries such as ADT and we usually leave it out of larger refactorings because it's kind of in "maintenance-only" mode IIRC.
>
> I still do not understand what code can use this function on OSX and on OSX I build with `-DLLDB_USE_SYSTEM_DEBUGSERVER=ON` which probably won't build the new `lldb-server` then.

We build both `lldb-server` and `debugserver` on Darwin but we're only using `debugserver` by default there. And `LLDB_USE_SYSTEM_DEBUGSERVER` just makes us copy the (codesigned) system debugserver into our build directory instead of building our own (but we still build `lldb-server` with that option IIRC).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104856/new/

https://reviews.llvm.org/D104856