[Lldb-commits] [PATCH] D104281: [lldb][docs] Add reference docs for Lua scripting

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added a comment.

I'm a little suspicious about the changes to `conf.py`. Can you explain why they're necessary and what they're fixing?



================
Comment at: lldb/docs/conf.py:32-33
     # set by CMake.
-    sys.path.insert(0, os.getenv("LLDB_SWIG_MODULE"))
+    if os.getenv("LLDB_SWIG_MODULE") is not None:
+        sys.path.insert(0, os.getenv("LLDB_SWIG_MODULE"))
 
----------------
Why is this necessary? It sounds like CMake should be setting this variable.


================
Comment at: lldb/docs/conf.py:64-77
 try:
-  import recommonmark
+    import recommonmark
 except ImportError:
-  # manpages do not use any .md sources
-  if not building_man_page:
-    raise
+    # manpages do not use any .md sources
+    if not building_man_page:
+        raise
 else:
----------------
Unrelated change? 


================
Comment at: lldb/docs/conf.py:180-182
+# Add any extra stylesheets and scripts here.
+html_css_files = ['lldb.css']
+html_js_files = []
----------------
Why is this necessary?


================
Comment at: lldb/docs/conf.py:306-308
+    ('index', 'LLDB', u'LLDB Documentation',
+     u'The LLDB Team', 'LLDB', 'One line description of project.',
+     'Miscellaneous'),
----------------
Unrelated whitespace change?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104281/new/

https://reviews.llvm.org/D104281