[Lldb-commits] [lldb] 1265f05 - [lldb] Skip TestLimitDebugInfo for Clang<7

[Raphael Isemann via lldb-commits]

Author: Raphael Isemann
Date: 2021-06-21T19:46:29+02:00
New Revision: 1265f05c268f09c74a2ecaa3e2b3cea83ec10627

URL: https://github.com/llvm/llvm-project/commit/1265f05c268f09c74a2ecaa3e2b3cea83ec10627
DIFF: https://github.com/llvm/llvm-project/commit/1265f05c268f09c74a2ecaa3e2b3cea83ec10627.diff

LOG: [lldb] Skip TestLimitDebugInfo for Clang<7

Without DW_CC_pass_by_* attributes that Clang 7 started to emit in this test
we don't properly read back the return value of the `get_*` functions and just
read bogus memory.

See also the TestReturnValue.py test.

Added: 
    

Modified: 
    lldb/test/API/functionalities/limit-debug-info/TestLimitDebugInfo.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/functionalities/limit-debug-info/TestLimitDebugInfo.py b/lldb/test/API/functionalities/limit-debug-info/TestLimitDebugInfo.py
index f9934df4eda4b..60dd7cf962821 100644
--- a/lldb/test/API/functionalities/limit-debug-info/TestLimitDebugInfo.py
+++ b/lldb/test/API/functionalities/limit-debug-info/TestLimitDebugInfo.py
@@ -32,6 +32,9 @@ def _check_debug_info_is_limited(self, target):
 
     @skipIf(bugnumber="pr46284", debug_info="gmodules")
     @skipIfWindows # Clang emits type info even with -flimit-debug-info
+    # Requires DW_CC_pass_by_* attributes from Clang 7 to correctly call
+    # by-value functions.
+    @skipIf(compiler="clang", compiler_version=['<', '7.0'])
     def test_one_and_two_debug(self):
         self.build()
         target = self.dbg.CreateTarget(self.getBuildArtifact("a.out"))
@@ -68,6 +71,9 @@ def test_one_and_two_debug(self):
 
     @skipIf(bugnumber="pr46284", debug_info="gmodules")
     @skipIfWindows # Clang emits type info even with -flimit-debug-info
+    # Requires DW_CC_pass_by_* attributes from Clang 7 to correctly call
+    # by-value functions.
+    @skipIf(compiler="clang", compiler_version=['<', '7.0'])
     def test_two_debug(self):
         self.build(dictionary=dict(STRIP_ONE="1"))
         target = self.dbg.CreateTarget(self.getBuildArtifact("a.out"))
@@ -108,6 +114,9 @@ def test_two_debug(self):
 
     @skipIf(bugnumber="pr46284", debug_info="gmodules")
     @skipIfWindows # Clang emits type info even with -flimit-debug-info
+    # Requires DW_CC_pass_by_* attributes from Clang 7 to correctly call
+    # by-value functions.
+    @skipIf(compiler="clang", compiler_version=['<', '7.0'])
     def test_one_debug(self):
         self.build(dictionary=dict(STRIP_TWO="1"))
         target = self.dbg.CreateTarget(self.getBuildArtifact("a.out"))