[Lldb-commits] [lldb] 7f20e6a - [lldb][NFC] Remove redundant deleted constructors in HostInfoBase subclasses

[Raphael Isemann via lldb-commits]

Author: Raphael Isemann
Date: 2021-06-21T13:33:40+02:00
New Revision: 7f20e6ae3229664f866149a4e0739a426b6fa463

URL: https://github.com/llvm/llvm-project/commit/7f20e6ae3229664f866149a4e0739a426b6fa463
DIFF: https://github.com/llvm/llvm-project/commit/7f20e6ae3229664f866149a4e0739a426b6fa463.diff

LOG: [lldb][NFC] Remove redundant deleted constructors in HostInfoBase subclasses

HostInfoBase has a deleted dtor/ctor so there is no need to do the same for
all the classes inheriting from it.

Reviewed By: DavidSpickett, JDevlieghere

Differential Revision: https://reviews.llvm.org/D104221

Added: 
    

Modified: 
    lldb/include/lldb/Host/linux/HostInfoLinux.h
    lldb/include/lldb/Host/macosx/HostInfoMacOSX.h
    lldb/include/lldb/Host/windows/HostInfoWindows.h

Removed: 
    


################################################################################
diff  --git a/lldb/include/lldb/Host/linux/HostInfoLinux.h b/lldb/include/lldb/Host/linux/HostInfoLinux.h
index 4a7bb6cc11fbb..3220046488677 100644
--- a/lldb/include/lldb/Host/linux/HostInfoLinux.h
+++ b/lldb/include/lldb/Host/linux/HostInfoLinux.h
@@ -21,11 +21,6 @@ namespace lldb_private {
 class HostInfoLinux : public HostInfoPosix {
   friend class HostInfoBase;
 
-private:
-  // Static class, unconstructable.
-  HostInfoLinux();
-  ~HostInfoLinux();
-
 public:
   static void Initialize(SharedLibraryDirectoryHelper *helper = nullptr);
   static void Terminate();

diff  --git a/lldb/include/lldb/Host/macosx/HostInfoMacOSX.h b/lldb/include/lldb/Host/macosx/HostInfoMacOSX.h
index ee9f12a90943f..4623932ab2b4c 100644
--- a/lldb/include/lldb/Host/macosx/HostInfoMacOSX.h
+++ b/lldb/include/lldb/Host/macosx/HostInfoMacOSX.h
@@ -21,11 +21,6 @@ class ArchSpec;
 class HostInfoMacOSX : public HostInfoPosix {
   friend class HostInfoBase;
 
-private:
-  // Static class, unconstructable.
-  HostInfoMacOSX() = delete;
-  ~HostInfoMacOSX() = delete;
-
 public:
   static llvm::VersionTuple GetOSVersion();
   static llvm::VersionTuple GetMacCatalystVersion();

diff  --git a/lldb/include/lldb/Host/windows/HostInfoWindows.h b/lldb/include/lldb/Host/windows/HostInfoWindows.h
index 400a3f4649bdd..f01113e900493 100644
--- a/lldb/include/lldb/Host/windows/HostInfoWindows.h
+++ b/lldb/include/lldb/Host/windows/HostInfoWindows.h
@@ -19,11 +19,6 @@ class UserIDResolver;
 class HostInfoWindows : public HostInfoBase {
   friend class HostInfoBase;
 
-private:
-  // Static class, unconstructable.
-  HostInfoWindows();
-  ~HostInfoWindows();
-
 public:
   static void Initialize(SharedLibraryDirectoryHelper *helper = nullptr);
   static void Terminate();