[Lldb-commits] [PATCH] D104525: [lldb] Assert that CommandResultObject error messages are not empty

[Raphael Isemann via Phabricator via lldb-commits]

teemperor added a comment.

LGTM, thanks for cleaning this up.

If we're anyway signing up @DavidSpickett for refactoring duty: `CommandReturnObject::SetError(llvm::StringRef error_str)` is clearly the same method as `CommandReturnObject::AppendError`, so one of those probably should go the way of the dodo. (Mostly kidding here, you don't have to refactor this too unless you have some time to spare)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104525/new/

https://reviews.llvm.org/D104525