[Lldb-commits] [PATCH] D103701: [lldb] Set return status to failed when adding a command error

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

This seems like a good change to me.  And even if you wanted to do something cheesy like put an error into the result on spec, then later decide it was successful after all, you can always reset the result's status to the appropriate success status.  This just makes the common practice less error prone.  We should also remove all the redundant settings, leaving them in would be confusing.  So I'd just make the change then fix whatever the bots bring up.

As to the bool from DoExecute, that also seems like a nice cleanup, but since you have to return something or the code doesn't compile, that's one that is harder to get wrong.  Plus it would be a tedious to fix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103701/new/

https://reviews.llvm.org/D103701