[Lldb-commits] [PATCH] D103701: [lldb] Set return status to failed when adding a command error

David Spickett via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jun 4 09:03:28 PDT 2021


DavidSpickett added a comment.
Herald added a subscriber: JDevlieghere.

There are likely other tests that aren't enabled for x86/AArch64 or sets of registers that I don't have on my machines. So if this change is welcome then the plan would be to land this as is and monitor the bots for a week or so, revert and reland with test fixups as needed.

Then I can remove the now redundant SetStatus calls, which I've done locally and goes from ~580 to ~50. Again, in batches to account for tests I'm not running.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103701/new/

https://reviews.llvm.org/D103701



More information about the lldb-commits mailing list