[Lldb-commits] [PATCH] D103210: [lldb] Introduce Language::MethodNameInfo

Thu Jun 3 15:12:47 PDT 2021

bulbazord added a comment.

In D103210#2795619 <https://reviews.llvm.org/D103210#2795619>, @teemperor wrote:

>> We have a method called `Language::GetMethodNameVariants`, that could be extended/modified to be more suitable. Unless you had something else in mind? Maybe something more specific to Symtab mapping like `Language::GetFunctionNameSearchVariants`.
>
> That actually seems like a great idea! `Module::LookupInfo` also seems quite close to the data structure we would need to return, so we could in theory return a list of that from the function instead.

Awesome, I'll work on that next :)

>> This makes sense to me, I'll also make this change in this patch :)
>
> Feel free to also put it up as a NFC patch. It seems in general like a good cleanup from what I can see, so that should be a quick review :)

Just uploaded: D103652 <https://reviews.llvm.org/D103652>

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103210/new/

https://reviews.llvm.org/D103210