[Lldb-commits] [PATCH] D103588: [trace] Create a global instruction class

[walter erquinigo via Phabricator via lldb-commits]

wallace created this revision.
wallace added a reviewer: clayborg.
Herald added a subscriber: kristof.beyls.
wallace requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

We want to start doing some analisis at instruction level, including stack trace reconstruction, trace summarization and security analysis. For this we need to provide a basic and efficient Instruction class without the symbolication bits for quick analysis. This class should be at Trace.h level abstracting plug-in dependent information.

I'm adding such as a class in Trace.h. It takes 16 bytes due to alignment, but if some unions are created, there should be 7 bytes available for other information without increazing the effective size of the class.

The most interesting part of this class is the TraceInstructionType enum inspired by libipt's pt_insn_class, which is generic enough to be used by other architectures like ARM.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D103588

Files:
  lldb/include/lldb/Target/Trace.h
  lldb/include/lldb/lldb-enumerations.h
  lldb/source/Plugins/Trace/intel-pt/DecodedThread.cpp
  lldb/source/Plugins/Trace/intel-pt/DecodedThread.h
  lldb/source/Plugins/Trace/intel-pt/IntelPTDecoder.cpp
  lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp
  lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.h
  lldb/source/Target/Trace.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D103588.349448.patch
Type: text/x-patch
Size: 23199 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20210603/6c13bcfb/attachment-0001.bin>