[Lldb-commits] [PATCH] D103349: [lldb] Don't print script output twice in HandleCommand
Jonas Devlieghere via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Jun 1 11:25:56 PDT 2021
JDevlieghere marked 2 inline comments as done.
JDevlieghere added inline comments.
Comment at: lldb/include/lldb/Interpreter/CommandReturnObject.h:169
+ /// as a temporary.
+ bool m_hermetic;
> bool m_hermetic = false;
This is the second time someone has suggested to use in-class member initializers. It's not what we've been doing in LLDB so far, but I am a fan of it personally, so I'm going to interpret this as what we want to do moving forward. I believe it's even a C++ core guideline. Maybe we can have a clang tidy check to enforce this.
Comment at: lldb/source/Interpreter/CommandReturnObject.cpp:155
m_interactive = true;
+ m_hermetic = false;
> or this
We would still need this :-)
CHANGES SINCE LAST ACTION
More information about the lldb-commits