[Lldb-commits] [PATCH] D103439: [lldb] Print the backtrace for all threads if the test breakpoint can't be hit
Jim Ingham via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Jun 1 10:42:30 PDT 2021
jingham added a comment.
In D103439#2791324 <https://reviews.llvm.org/D103439#2791324>, @teemperor wrote:
> In D103439#2791298 <https://reviews.llvm.org/D103439#2791298>, @JDevlieghere wrote:
>> LGTM. Are there other places where we check this, either in `lldbutil` or maybe more generally a pattern in the tests that could be extracted into a helper?
> From what I can see all our `lldbutil` functions that run to a breakpoint end up calling this function so this should cover everything beside the tests that manually do stuff like "continue" and so on. But there might be some utility function for going to the next breakpoint that are missing this. I'll check, thanks!
You probably also want to do this to "lldbutil.continue_to_breakpoint", except that doesn't actually do any tests. It should really be rewritten to take a TestBase and do the assert's in the function, it is inconvenient to use as currently written.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits