[Lldb-commits] [lldb] 01fb14e - [lldb] Remove SBCommandReturnObject::ref

[Raphael Isemann via lldb-commits]

Author: Raphael Isemann
Date: 2021-06-01T17:57:21+02:00
New Revision: 01fb14e17763269779f2c03b772db960540f47ed

URL: https://github.com/llvm/llvm-project/commit/01fb14e17763269779f2c03b772db960540f47ed
DIFF: https://github.com/llvm/llvm-project/commit/01fb14e17763269779f2c03b772db960540f47ed.diff

LOG: [lldb] Remove SBCommandReturnObject::ref

This function was added in D67589 and returns an internal CommandReturnObject
which isn't allowed in the SB API. This patch just makes it private as all uses
of this function are inside SBCommandReturnObject.

Reviewed By: jankratochvil

Differential Revision: https://reviews.llvm.org/D103390

Added: 
    

Modified: 
    lldb/include/lldb/API/SBCommandReturnObject.h

Removed: 
    


################################################################################
diff  --git a/lldb/include/lldb/API/SBCommandReturnObject.h b/lldb/include/lldb/API/SBCommandReturnObject.h
index 6e1e7adb82caf..5738c911ae125 100644
--- a/lldb/include/lldb/API/SBCommandReturnObject.h
+++ b/lldb/include/lldb/API/SBCommandReturnObject.h
@@ -105,9 +105,6 @@ class LLDB_API SBCommandReturnObject {
 
   void SetError(const char *error_cstr);
 
-  // ref() is internal for LLDB only.
-  lldb_private::CommandReturnObject &ref() const;
-
 protected:
   friend class SBCommandInterpreter;
   friend class SBOptions;
@@ -119,6 +116,8 @@ class LLDB_API SBCommandReturnObject {
   lldb_private::CommandReturnObject &operator*() const;
 
 private:
+  lldb_private::CommandReturnObject &ref() const;
+
   std::unique_ptr<lldb_private::SBCommandReturnObjectImpl> m_opaque_up;
 };