[Lldb-commits] [PATCH] D103391: [lldb] Add missing reproducer instrumentation to some SB classes

[Raphael Isemann via Phabricator via lldb-commits]

teemperor created this revision.
teemperor added a reviewer: JDevlieghere.
teemperor added a project: LLDB.
teemperor requested review of this revision.
Herald added a subscriber: lldb-commits.

I noticed that there might be some missing instrumentation after a related change popped up in D103381 <https://reviews.llvm.org/D103381>.
This patch is just the result of running lldb-instr over the different parts of the SB API implementations (+ some manual filtering).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D103391

Files:
  lldb/source/API/SBDebugger.cpp
  lldb/source/API/SBModuleSpec.cpp
  lldb/source/API/SBTrace.cpp


Index: lldb/source/API/SBTrace.cpp
===================================================================
--- lldb/source/API/SBTrace.cpp
+++ lldb/source/API/SBTrace.cpp
@@ -77,6 +77,9 @@
 }
 
 void SBTrace::GetTraceConfig(SBTraceOptions &options, SBError &error) {
+  LLDB_RECORD_METHOD(void, SBTrace, GetTraceConfig,
+                     (lldb::SBTraceOptions &, lldb::SBError &), options, error);
+
   error.SetErrorString("deprecated");
 }
 
Index: lldb/source/API/SBModuleSpec.cpp
===================================================================
--- lldb/source/API/SBModuleSpec.cpp
+++ lldb/source/API/SBModuleSpec.cpp
@@ -127,6 +127,8 @@
 }
 
 const uint8_t *SBModuleSpec::GetUUIDBytes() {
+  LLDB_RECORD_METHOD_NO_ARGS(const uint8_t *, SBModuleSpec, GetUUIDBytes);
+
   return m_opaque_up->GetUUID().GetBytes().data();
 }
 
@@ -137,6 +139,9 @@
 }
 
 bool SBModuleSpec::SetUUIDBytes(const uint8_t *uuid, size_t uuid_len) {
+  LLDB_RECORD_METHOD(bool, SBModuleSpec, SetUUIDBytes,
+                     (const uint8_t *, size_t), uuid, uuid_len);
+
   m_opaque_up->GetUUID() = UUID::fromOptionalData(uuid, uuid_len);
   return m_opaque_up->GetUUID().IsValid();
 }
Index: lldb/source/API/SBDebugger.cpp
===================================================================
--- lldb/source/API/SBDebugger.cpp
+++ lldb/source/API/SBDebugger.cpp
@@ -162,6 +162,11 @@
                                              uint64_t &completed,
                                              uint64_t &total,
                                              bool &is_debugger_specific) {
+  LLDB_RECORD_STATIC_METHOD(
+      const char *, SBDebugger, GetProgressFromEvent,
+      (const lldb::SBEvent &, uint64_t &, uint64_t &, uint64_t &, bool &),
+      event, progress_id, completed, total, is_debugger_specific);
+
   const Debugger::ProgressEventData *progress_data =
       Debugger::ProgressEventData::GetEventDataFromEvent(event.get());
   if (progress_data == nullptr)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D103391.348748.patch
Type: text/x-patch
Size: 1963 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20210531/c333e0fc/attachment.bin>