[Lldb-commits] [PATCH] D102140: [ppc64le] [lldb] [testsuite] Fix false FAILs on ppc64le with no hw watchpoints

[David Spickett via Phabricator via lldb-commits]

DavidSpickett added inline comments.


================
Comment at: lldb/test/API/commands/watchpoints/hello_watchpoint/TestMyFirstWatchpoint.py:68
+        except:
+            if self.getArchitecture() == 'powerpc64le' \
+               and "\nerror: Target supports (0) hardware watchpoint slots.\n" \
----------------
jankratochvil wrote:
> DavidSpickett wrote:
> > Is the arch check here needed, also should it include powerpc64be? (not very familiar with powerpc but your title says `ppc64*`)
> > 
> > I don't think it would harm to not check the arch.
> > Is the arch check here needed, also should it include powerpc64be? (not very familiar with powerpc but your title says `ppc64*`)
> 
> ppc64be is not supported by LLDB (and I expect it will never be as PowerPC has moved BE->LE).
> 
> 
> > I don't think it would harm to not check the arch.
> 
> I think it would harm. As if there is a regression LLDB falsely reports 0 watchpoints on all arches the testsuite will not find it out. Sure this possible uncaught regression affects also PPC but one cannot do anything with it there.
```
I think it would harm. As if there is a regression LLDB falsely reports 0 watchpoints on all arches the testsuite will not find it out. Sure this possible uncaught regression affects also PPC but one cannot do anything with it there.
```

True, I didn't think of it that way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102140/new/

https://reviews.llvm.org/D102140