[Lldb-commits] [PATCH] D102140: [ppc64le] [lldb] [testsuite] Fix false FAILs on ppc64* with no hw watchpoints

Wed May 19 07:56:59 PDT 2021

jankratochvil planned changes to this revision.
jankratochvil marked an inline comment as done.
jankratochvil added a comment.

In D102140#2768660 <https://reviews.llvm.org/D102140#2768660>, @DavidSpickett wrote:

> Is there any command we can run to directly get the number of h/w watchpoints?

Not aware of, I will check and/or code some, thanks for the review.

================
Comment at: lldb/test/API/commands/watchpoints/hello_watchpoint/TestMyFirstWatchpoint.py:68
+        except:
+            if self.getArchitecture() == 'powerpc64le' \
+               and "\nerror: Target supports (0) hardware watchpoint slots.\n" \
----------------
DavidSpickett wrote:
> Is the arch check here needed, also should it include powerpc64be? (not very familiar with powerpc but your title says `ppc64*`)
> 
> I don't think it would harm to not check the arch.
> Is the arch check here needed, also should it include powerpc64be? (not very familiar with powerpc but your title says `ppc64*`)

ppc64be is not supported by LLDB (and I expect it will never be as PowerPC has moved BE->LE).

> I don't think it would harm to not check the arch.

I think it would harm. As if there is a regression LLDB falsely reports 0 watchpoints on all arches the testsuite will not find it out. Sure this possible uncaught regression affects also PPC but one cannot do anything with it there.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102140/new/

https://reviews.llvm.org/D102140