[Lldb-commits] [PATCH] D102872: Fix lldb-server build failure on mips

[David Spickett via Phabricator via lldb-commits]

DavidSpickett added a comment.

I assume this is caused by the removal of the specific `NativeRegisterContextLinux_mips` and you are building lldb on MIPS but you're going to connect to another debug server (gdb, custom stub etc.).

The problem with doing it this way is then if you build on a supported platform e.g. AArch64 `NativeRegisterContextLinux_arm64` we then have two copies of CreateHostNativeRegisterContextLinux. Somehow this isn't an error on my system, and it picks up the one you've added. Meaning that you can't debug a simple hello world.

See the comment in `lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux.h`. (though again I'd have expect a hard linker error but anyway) Also the reason CI didn't fail is that lldb is disabled for both of the builds.

I can see the utility in allowing people to build at least lldb (client) on any platform. Perhaps we surround this in the `#ifdef` that the old mips register context used? Or modify our cmake to allow lldb-server to be disabled. (easier said than done)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102872/new/

https://reviews.llvm.org/D102872