[Lldb-commits] [PATCH] D101128: [lldb-vscode] only report long running progress events

walter erquinigo via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue May 18 15:52:10 PDT 2021


wallace added inline comments.


================
Comment at: lldb/tools/lldb-vscode/ProgressEvent.h:32
+  ProgressEvent(uint64_t progress_id, llvm::StringRef message,
+                llvm::Optional<uint32_t> percentage);
 
----------------
clayborg wrote:
> Why is there an optional percentage for a start event?
if total is INT_MAX, there's nothing to report


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101128/new/

https://reviews.llvm.org/D101128



More information about the lldb-commits mailing list