[Lldb-commits] [PATCH] D102685: [lldb] Encode `bool` as unsigned int

[Raphael Isemann via Phabricator via lldb-commits]

teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: JDevlieghere.

Nice, and it's not even my birthday. Just some nits that don't need another round of review.



================
Comment at: lldb/test/API/lang/cpp/bitfields/TestCppBitfields.py:21
-    # (http://llvm.org/pr21800)
-    @skipIfWindows
     def test_and_run_command(self):
----------------
Please land that as it's own commit (from what I understand from the bug report this worked before and you just remove the skipIf here)


================
Comment at: lldb/test/API/lang/cpp/bitfields/TestCppBitfields.py:131
+
+        bb = self.frame().FindVariable('bb')
+        bb_a = bb.GetChildAtIndex(0)
----------------
You might want to assert that `bb.IsValid()` after this call (otherwise the `GetValueAs*` calls just return 0 and that's a confusing error).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102685/new/

https://reviews.llvm.org/D102685