[Lldb-commits] [PATCH] D102685: [lldb] Encode `bool` as unsigned int
Raphael Isemann via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue May 18 06:12:11 PDT 2021
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: JDevlieghere.
Nice, and it's not even my birthday. Just some nits that don't need another round of review.
Comment at: lldb/test/API/lang/cpp/bitfields/TestCppBitfields.py:21
- # (http://llvm.org/pr21800)
Please land that as it's own commit (from what I understand from the bug report this worked before and you just remove the skipIf here)
Comment at: lldb/test/API/lang/cpp/bitfields/TestCppBitfields.py:131
+ bb = self.frame().FindVariable('bb')
+ bb_a = bb.GetChildAtIndex(0)
You might want to assert that `bb.IsValid()` after this call (otherwise the `GetValueAs*` calls just return 0 and that's a confusing error).
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits