[Lldb-commits] [PATCH] D102208: Remove Windows editline from LLDB
Neal via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue May 11 11:28:16 PDT 2021
nealsid added a comment.
I ran LLDB tests from a clean tree and with my change and the failures seemed to be the same, but there is a large amount of them. I also did manual testing with the changes. Build is still green.
Editline is only used when Cmake can find the editline libraries, which it never does on Windows. So the code that is actually used for console I/O is the code in the IOHandlerEditline class in IOHandler.cpp that is outside of the #ifdef LLDB_USE_EDITLINE preprocessor check. That uses POSIX functions for console I/O. I think it may be a good follow up change to make IOHandlerEditline be used in editline-specific cases and move the fallback/non-editline code in that class to another class.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits