[Lldb-commits] [PATCH] D102208: Remove Windows editline from LLDB

Adrian McCarthy via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue May 11 09:17:50 PDT 2021


amccarth added a subscriber: zturner.
amccarth added a comment.

It looks like this EditLine port was added before I joined this project.  @zturner may have worked on it, but I don't know/remember.

If it's actually unused, I have no objection to removing it.  I harbor some hope that Windows's steadily improving unix-like terminal implementation (which console programs can enable) will eventually make a Windows-port of EditLine trivial.

I concur that the MSVC version tweak should be a separate change.  If you remove that from this patch, I'll LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102208/new/

https://reviews.llvm.org/D102208



More information about the lldb-commits mailing list