[Lldb-commits] [PATCH] D102208: Remove Windows editline from LLDB
Neal via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon May 10 19:25:19 PDT 2021
nealsid created this revision.
nealsid added reviewers: LLDB, kparzysz.
Herald added subscribers: hiraditya, krytarowski, mgorny.
nealsid requested review of this revision.
Herald added projects: LLDB, LLVM.
Herald added subscribers: llvm-commits, lldb-commits.
I don't mean to undo others' work but it looks like the hand-rolled EditLine for LLDB on Windows isn't used. It'd be easier to make changes to bring the other platforms' Editline wrapper up to date (e.g. simplifying char vs wchar_t) without modifying/testing this one too. I also modified an #ifdef check for the MSVC version number to increase it, as it happens on VS2019, too.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D102208
Files:
lldb/include/lldb/Host/Editline.h
lldb/include/lldb/Host/windows/editlinewin.h
lldb/source/Host/CMakeLists.txt
lldb/source/Host/windows/EditLineWin.cpp
llvm/lib/Target/Hexagon/HexagonVectorCombine.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D102208.344270.patch
Type: text/x-patch
Size: 15701 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20210511/5245d846/attachment-0001.bin>
More information about the lldb-commits
mailing list