[Lldb-commits] [PATCH] D101903: [LLDB] Don't use the local python to set a default for LLDB_PYTHON_RELATIVE_PATH when cross compiling.
Jonas Devlieghere via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed May 5 08:38:04 PDT 2021
JDevlieghere accepted this revision.
JDevlieghere added inline comments.
This revision is now accepted and ready to land.
================
Comment at: lldb/CMakeLists.txt:48
+ message(FATAL_ERROR
+ "Crosscompiling with python requires manually setting
+ LLDB_PYTHON_RELATIVE_PATH.")
----------------
Are there other reasons `LLDB_PYTHON_RELATIVE_PATH` could be empty at this point, unrelated to cross compilation? Would it make sense to move the error in the else clause of `if (NOT CMAKE_CROSSCOMPILING)` instead?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101903/new/
https://reviews.llvm.org/D101903
More information about the lldb-commits
mailing list