[Lldb-commits] [PATCH] D100740: [trace] Dedup different source lines when dumping instructions + refactor

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue May 4 13:22:04 PDT 2021

clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.

Just fix the one issue where we use the FileSpec operator== and this is good to go!

Comment at: lldb/source/Core/AddressRange.cpp:59
+  // the file addresses in this case only.
+  return ContainsFileAddress(addr);
It might be worth scanning the code to see if anyone is using AddressRange::ContainsFileAddress() incorrectly. It is fine to use this within a module to check if an address is in the range, but not ok if the address can come from a different module.

Comment at: lldb/source/Target/Trace.cpp:114
+  return FileSpec::Compare(a.file, b.file, true) == 0;
No need to compare, just use == operator

  rG LLVM Github Monorepo



More information about the lldb-commits mailing list