[Lldb-commits] [PATCH] D101361: [LLDB] Support AArch64/Linux watchpoint on tagged addresses

[David Spickett via Phabricator via lldb-commits]

DavidSpickett added a reviewer: mgorny.
DavidSpickett added a subscriber: mgorny.
DavidSpickett added a comment.

@mgorny Does FreeBSD do anything with the top byte ignore feature?



================
Comment at: lldb/source/Plugins/Process/Utility/NativeRegisterContextDBReg_arm64.cpp:476
+  return hit_addr & ((1ULL << 56) - 1);
+}
----------------
I think it was fine where it was, my point was just to check whether FreeBSD enables TBI at all.

Seems like it should be an OS level query. 99% of the time we'd be fine assuming it's enabled but I don't like the idea of pretending that it is and giving a false impression.

Unless assuming TBI is safe just because the hardware registers don't hold those bits anyway. In which case the comment should justify that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101361/new/

https://reviews.llvm.org/D101361