[Lldb-commits] [PATCH] D100965: [lldb] Refactor argument group by SourceLocationSpec (NFCI)
Jonas Devlieghere via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon May 3 14:34:43 PDT 2021
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
Comment at: lldb/source/Breakpoint/BreakpointResolverFileLine.cpp:266-272
+ s->Printf("file = '%s', line = %u, ",
+ auto column = m_location_spec.GetColumn();
+ if (column)
+ s->Printf("column = %u, ", *column);
+ s->Printf("exact_match = %d", m_location_spec.GetExactMatch());
I was going to suggest calling the location spec's dump method, but I assume we don't want to change the format. Would it make sense to have a `GetDescription` in the SourceLocationSpec class or change the dump format to match this format?
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits