[Lldb-commits] [PATCH] D101627: [lldb] More tests for DumpDataExtractor

[Jim Ingham via lldb-commits]

I would resist this change.  It's unnecessarily disruptive, would again break git archeology, and really have no significant benefit.  I also think the lldb conventions for naming things are much clearer than the llvm ones.  Knowing that something is a ivar by looking at the name is a real timesaver, especially for people new to the code.  Being able to tell local variables from other entities by looking also makes reading code much easier.  Etc...

I would be willing to discuss reformatting the llvm codebase to follow the lldb conventions, however...

Jim


> On Apr 30, 2021, at 8:52 AM, Raphael Isemann via Phabricator via lldb-commits <lldb-commits at lists.llvm.org> wrote:
> 
> teemperor added a comment.
> 
> Jepp, they are capitalized :)
> 
> FWIW, maybe we should see if we can fix this at the next US dev meeting (which hopefully happens). git has by now a filter for mass-refactors so the only problem is getting everyone to on board with breaking the whole code base and make them rewrite the internal patches. Fun!
> 
> 
> Repository:
>  rG LLVM Github Monorepo
> 
> CHANGES SINCE LAST ACTION
>  https://reviews.llvm.org/D101627/new/
> 
> https://reviews.llvm.org/D101627
> 
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits