[Lldb-commits] [PATCH] D101627: [lldb] More tests for DumpDataExtractor

[David Spickett via Phabricator via lldb-commits]

DavidSpickett added inline comments.


================
Comment at: lldb/unittests/Core/DumpDataExtractorTest.cpp:40
+}
+
+static void testDumpWithOffset(offset_t start_offset,
----------------
DavidSpickett wrote:
> teemperor wrote:
> > I think you missed the capitalisation here and in the function above :)
> Doh. In fact it's the opposite, TestDump... should be testDump.... at least according to llvm style.
> 
> https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly
> 
> Does lldb differ there too?
> 
> https://lldb.llvm.org/resources/contributing.html
> 
> (maybe I can contribute some writeup of these differences)
Well now I look at some random files, yes it differs. I thought maybe only member functions were FooBar but that applies all over. I'll fix it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101627/new/

https://reviews.llvm.org/D101627