[Lldb-commits] [PATCH] D101627: [lldb] More tests for DumpDataExtractor
David Spickett via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Fri Apr 30 08:18:31 PDT 2021
DavidSpickett added a comment.
> The_underscore_style_for_functions isn't LLDB (or LLVM) code style. I missed that in the first review. So just rename the utility functions to TestDumpMultiline and so on and this LGTM. I'm just going to accept this as renaming the variables shouldn't need another review.
I take it that LLDB is also following the variable naming style then? At least for new code, older code like what this is testing doesn't.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101627/new/
https://reviews.llvm.org/D101627
More information about the lldb-commits
mailing list