[Lldb-commits] [PATCH] D101631: [lldb] DumpDataExtractor tests for item byte size errors

[Raphael Isemann via Phabricator via lldb-commits]

teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.

LGTM, thanks for writing these. Please check the code style remark in D101627 <https://reviews.llvm.org/D101627> before merging this (you also need to change the functions here obviously)



================
Comment at: lldb/unittests/Core/DumpDataExtractorTest.cpp:205
   test_dump<double>(10, lldb::Format::eFormatHexFloat, "0x1.4p3");
-  // Long double we don't support and format an error saying so.
-  // However sizeof(long double) is 8/12/16 depending on the host so not tested
-  // here.
+  // long double not supported, eee ItemByteSizeErrors.
 
----------------
`eee` -> `see`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101631/new/

https://reviews.llvm.org/D101631