[Lldb-commits] [PATCH] D101556: [lldb] Move and clean-up the Declaration class (NFC)

[Med Ismail Bennani via Phabricator via lldb-commits]

mib added a comment.

In D101556#2726434 <https://reviews.llvm.org/D101556#2726434>, @teemperor wrote:

> IIRC they were #ifdef's out because of memory concerns. Did you have a chance to benchmark this quickly (e.g., trying to attach to a debug Clang and see how much it increases memory)
>
> Otherwise this LGTM.
>
> FWIW, we also need this for the SourceLocation in Clang Decls feature I was working on some time ago.

I ran a benchmark as you suggested, attaching to a debug clang build, checking lldb's memory before starting the process (650MB), setting a breakpoint to main then launching the process (~1GB), and after the process stops, I tried evaluating the following expression : `(lldb) expr std::string("This is a string.", 4)` (4.83GB) and the memory usage matched in both scenarios.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101556/new/

https://reviews.llvm.org/D101556