[Lldb-commits] [PATCH] D101556: [lldb] Move and clean-up the	Declaration class (NFC)
    Raphael Isemann via Phabricator via lldb-commits 
    lldb-commits at lists.llvm.org
       
    Thu Apr 29 11:47:37 PDT 2021
    
    
  
teemperor added a comment.
IIRC they were #ifdef's out because of memory concerns. Did you have a chance to benchmark this quickly (e.g., trying to attach to a debug Clang and see how much it increases memory)
Otherwise this LGTM.
FWIW, we also need this for the SourceLocation in Clang Decls feature I was working on some time ago.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101556/new/
https://reviews.llvm.org/D101556
    
    
More information about the lldb-commits
mailing list