[Lldb-commits] [PATCH] D101390: Change Target::ReadMemory to ensure the amount of memory read from the file-cache is the amount requested.

[Augusto Noronha via Phabricator via lldb-commits]

augusto2112 marked 2 inline comments as done.
augusto2112 added inline comments.


================
Comment at: lldb/source/Target/Target.cpp:1818
 
-  if (!is_readonly && resolved_addr.IsSectionOffset()) {
+  if (file_cache_read_buffer.get() && file_cache_bytes_read > 0) {
+    // Reading from the process failed. If we've previously succeeded in reading
----------------
JDevlieghere wrote:
> The `unique_ptr` provides an operator bool, so you don't need to check the underlying pointer yourself. 
Thanks Jonas!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101390/new/

https://reviews.llvm.org/D101390