[Lldb-commits] [PATCH] D101390: Change Target::ReadMemory to ensure the amount of memory read from the file-cache is the amount requested.

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added inline comments.


================
Comment at: lldb/source/Target/Target.cpp:1818
 
-  if (!is_readonly && resolved_addr.IsSectionOffset()) {
+  if (file_cache_read_buffer.get() && file_cache_bytes_read > 0) {
+    // Reading from the process failed. If we've previously succeeded in reading
----------------
The `unique_ptr` provides an operator bool, so you don't need to check the underlying pointer yourself. 


================
Comment at: lldb/source/Target/Target.cpp:1825
+
+  if (!file_cache_read_buffer.get() && resolved_addr.IsSectionOffset()) {
     // If we didn't already try and read from the object file cache, then try
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101390/new/

https://reviews.llvm.org/D101390