[Lldb-commits] [PATCH] D101462: Make it possible for targets to define their own MCObjectFileInfo

Philipp Krones via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Apr 29 05:51:52 PDT 2021


flip1995 added a comment.

Thanks for the review! I already thought that I will have to split this up, so I made the commits self contained so I'll do that. One question before I start:

Where should I split this? Should I only split out the RISC-V patch and leave the changes that targets can define their own `MCObjectFileInfo` in (commit a1b3a604a410), or should I also split out that part? Personally I would keep this change in the refactor PR and only split out the RISC-V changes.

---

About the alignment change: I guess we can discuss this then specifically for RISC-V in the split out review. But the short answer is: The main motivation is improving code size a bit, since less padding has to be added between functions. If function alignment is important `-align-all-functions=X` could be used.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101462/new/

https://reviews.llvm.org/D101462



More information about the lldb-commits mailing list