[Lldb-commits] [PATCH] D100493: [lldb][AArch64] Don't check for VmFlags in smaps files

[David Spickett via Phabricator via lldb-commits]

DavidSpickett added inline comments.


================
Comment at: lldb/test/API/linux/aarch64/mte_memory_region/TestAArch64LinuxMTEMemoryRegion.py:42
 
         if self.process().GetState() == lldb.eStateExited:
             self.fail("Test program failed to run.")
----------------
omjavaid wrote:
> I think this is LGTM as it is but if you want to add further reliability then may be set a unique executable name so that you can detect only its PID and then read smaps file. You can skip this test at this stage if target doesnt have smaps. 
That's clever, I didn't think of that. I might do that in a follow up.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100493/new/

https://reviews.llvm.org/D100493