[Lldb-commits] [PATCH] D100493: [lldb][AArch64] Don't check for VmFlags in smaps files

Muhammad Omair Javaid via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Apr 28 19:03:58 PDT 2021


omjavaid accepted this revision.
omjavaid added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lldb/test/API/linux/aarch64/mte_memory_region/TestAArch64LinuxMTEMemoryRegion.py:42
 
         if self.process().GetState() == lldb.eStateExited:
             self.fail("Test program failed to run.")
----------------
I think this is LGTM as it is but if you want to add further reliability then may be set a unique executable name so that you can detect only its PID and then read smaps file. You can skip this test at this stage if target doesnt have smaps. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100493/new/

https://reviews.llvm.org/D100493



More information about the lldb-commits mailing list