[Lldb-commits] [PATCH] D101131: [lldb-vscode] Follow up of D99989 - store some strings more safely

[Shafik Yaghmour via Phabricator via lldb-commits]

shafik added inline comments.


================
Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:925
     lldb::SBDeclaration declaration = v.GetDeclaration();
-    std::string file_name(declaration.GetFileSpec().GetFilename());
     const uint32_t line = declaration.GetLine();
----------------
wallace wrote:
> i had to change this because std::string(nullptr) throws on my machine
Yes, the `std::string` constructor taking a `const CharT*` expects a null terminated C-string.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101131/new/

https://reviews.llvm.org/D101131