[Lldb-commits] [PATCH] D97282: [lldb][AArch64] Add memory-tagging qSupported feature

[David Spickett via Phabricator via lldb-commits]

DavidSpickett added a subscriber: mgorny.
DavidSpickett added a comment.

@mgorny Can you take a quick look and see if I'm adding this new feature correctly?

And thanks for working on qSupported. I skipped checking HWCAP in my first revision because the features were added in generic code, now I can be more accurate in the Linux specific method.



================
Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:297
+  if ((getauxval(AT_HWCAP2) & HWCAP2_MTE))
+    supported |= Extension::memory_tagging;
+
----------------
There is a mechanism to get auvx from a process but I don't think we have one at this point.


================
Comment at: lldb/test/API/tools/lldb-server/TestLldbGdbServer.py:1034
+        self.assertEqual(supported_dict.get("memory-tagging", '-'),
+                         '+' if self.isAArch64MTE() else '-')
+
----------------
For the moment my MTE test target is in fact, a remote platform in QEMU. But at least this checks that no one else gets the feature incorrectly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97282/new/

https://reviews.llvm.org/D97282