[Lldb-commits] [PATCH] D100459: [lldb] [gdb-remote client] Refactor SetCurrentThread*()

[Diana Picus via Phabricator via lldb-commits]

rovka added a comment.

This looks good to me, but I'll let others comment on whether or not we want to send extra leading zeroes for the thread ID. In my opinion it would be nice to 1) be consistent between all packages that deal with thread ids, and 2) send as little clutter as possible. But these are just theoretical concerns, I'm not sure if it matters in practice.



================
Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h:337
 
+  llvm::Optional<uint64_t> SendSetCurrentThreadPacket(uint64_t tid, char type);
+
----------------
Nitpick: You could call this 'op' instead of 'type', to match the [[ https://sourceware.org/gdb/onlinedocs/gdb/Packets.html#Packets | documentation ]] for the H packet.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100459/new/

https://reviews.llvm.org/D100459