[Lldb-commits] [PATCH] D101406: Rename human-readable name for DW_LANG_Mips_Assembler

[Adrian Prantl via Phabricator via lldb-commits]

aprantl created this revision.
aprantl added reviewers: JDevlieghere, labath, jasonmolenda, jingham, clayborg.
Herald added subscribers: atanasyan, arichardson, sdardis.
aprantl requested review of this revision.

The Mips in DW_LANG_Mips_Assembler is a vendor name not an architecture name and in lack of a proper generic DW_LANG_assembler, some assemblers emit DWARF using this tag. Due to a warning I recently introduced users will now be greeted with

  This version of LLDB has no plugin for the mipsassem language. Inspection of frame variables will be limited.

What about renaming this to just assembler? Are there any risks in doing so?

rdar://77214764


https://reviews.llvm.org/D101406

Files:
  lldb/source/Target/Language.cpp


Index: lldb/source/Target/Language.cpp
===================================================================
--- lldb/source/Target/Language.cpp
+++ lldb/source/Target/Language.cpp
@@ -184,7 +184,7 @@
     {"fortran03", eLanguageTypeFortran03},
     {"fortran08", eLanguageTypeFortran08},
     // Vendor Extensions
-    {"mipsassem", eLanguageTypeMipsAssembler},
+    {"assembly", eLanguageTypeMipsAssembler},
     {"renderscript", eLanguageTypeExtRenderScript},
     // Now synonyms, in arbitrary order
     {"objc", eLanguageTypeObjC},


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D101406.341005.patch
Type: text/x-patch
Size: 536 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20210427/ae5b34ef/attachment.bin>