[Lldb-commits] [PATCH] D99947: [LLDB] AArch64 Linux PAC unwinder support

Tue Apr 27 07:13:37 PDT 2021

DavidSpickett added a comment.

In D99947#2719403 <https://reviews.llvm.org/D99947#2719403>, @omjavaid wrote:

> In D99947#2718954 <https://reviews.llvm.org/D99947#2718954>, @DavidSpickett wrote:
>
>> Did the changes in `GDBRemoteRegisterContext.cpp` (https://reviews.llvm.org/D99947?id=335484#inline-940747 ) get moved to another diff?
>
> We no longer need to configure Address bits in use after changes from D100521 <https://reviews.llvm.org/D100521> and D99944 <https://reviews.llvm.org/D99944> get merged. ABISysV_arm64 now contains the logic for masking of ignored bits from code and data addresses. Look through overrides of FixCodeAddress and FixDataAddress in D99944 <https://reviews.llvm.org/D99944>.

Seems like you could merge them completely in that case. Make one commit that adds tests for core files and real targets.

(FWIW this LGTM with the comment for _start added)

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99947/new/

https://reviews.llvm.org/D99947