[Lldb-commits] [PATCH] D101241: [lldb] [llgs] Report QPassSignals and qXfer via extensions API

[Michał Górny via Phabricator via lldb-commits]

mgorny added inline comments.


================
Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:287
+  return Extension::multiprocess | Extension::fork | Extension::vfork |
+         Extension::pass_signals | Extension::auxv | Extension::libraries_svr4;
 }
----------------
labath wrote:
> Technically, `libraries_svr4` functionality is implemented in the base class, so it would be more correct to implement this as `| NativeProcessELF::Factory::GetSupportedExtensions()` (this would be a new class, which exists only to override `GetSupportedExtensions`).
Doesn't it require some extra logic in the `NativeProcess*` class though, like memory maps or something like that? If not, I sure can move it, I guess.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101241/new/

https://reviews.llvm.org/D101241