[Lldb-commits] [PATCH] D100554: [lldb] [Process/NetBSD] Report fork/vfork events to LLGS

[Michał Górny via Phabricator via lldb-commits]

mgorny added inline comments.


================
Comment at: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:138
+NativeProcessNetBSD::Factory::GetSupportedExtensions() const {
+  return Extension::multiprocess | Extension::fork | Extension::vfork;
+}
----------------
labath wrote:
> Why did we end up with a multiprocess extension? I'd think that support for that is implemented completely inside the gdb-remote class, and there's no need to advertise it's availability by the process plugin?
Primarily to make things more consistent and to avoid confusion. For example, right now LLGS strips away extensions that are not supported by the plugin. If plugin didn't report `Extension::multiprocess`, we'd have to add more special cases to the LLGS code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100554/new/

https://reviews.llvm.org/D100554