[Lldb-commits] [PATCH] D99947: [LLDB] AArch64 Linux PAC unwinder support

[David Spickett via Phabricator via lldb-commits]

DavidSpickett added a comment.

Did the changes in `GDBRemoteRegisterContext.cpp` (https://reviews.llvm.org/D99947?id=335484#inline-940747 ) get moved to another diff?



================
Comment at: lldb/test/API/functionalities/unwind/aarch64_unwind_pac/TestAArch64UnwindPAC.py:41
+            self.assertEqual(frame.GetFunctionName(), backtrace[frame_idx])
+            if (frame_idx < 4):
+                self.assertEqual(frame.GetLineEntry().GetLine(),
----------------
Add a comment here to explain that `_start` isn't in main.c, so we don't check for its line number. (took me a bit to work that out)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99947/new/

https://reviews.llvm.org/D99947