[Lldb-commits] [PATCH] D101153: [lldb][NFC] Specify guidelines for API tests

Mon Apr 26 23:32:15 PDT 2021

jasonmolenda added a comment.

Nice addition, these are great guidelines.  I'd do a s/just// pass over the text, there's some extraneous "just"s that could go.  This is a very bad habit of my own lately, I re-read emails I write, and try to remove "justs" that snuck into the text I typed before I send.  I think my keyboard driver might be responsible for inserting them into sentences.

================
Comment at: lldb/docs/resources/test.rst:229
+    and makes the test much harder to debug and maintain. The test programs
+    should always be deterministic (i.e., do not generate and check against
+    random test values).
----------------
teemperor wrote:
> JDevlieghere wrote:
> > 
> Done. I actually believe the comma is correct (at least the internet says it is and if that's not a reliable source than what is).
two cents - if it were english, like "(that is, do not generate", I'd use a comma. I've never thought about which is correct with "i.e." but if I were thinking about it, I'd go with a comma.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101153/new/

https://reviews.llvm.org/D101153