[Lldb-commits] [PATCH] D99941: [LLDB] Support AArch64 PAC elf-core register read

[Muhammad Omair Javaid via Phabricator via lldb-commits]

omjavaid marked an inline comment as done.
omjavaid added inline comments.


================
Comment at: lldb/source/Plugins/Process/elf-core/RegisterContextPOSIXCore_arm64.cpp:32
+  if (pac_data.GetByteSize() > sizeof(uint64_t))
+    opt_regsets.Set(RegisterInfoPOSIX_arm64::eRegsetMaskPAuth);
+
----------------
DavidSpickett wrote:
> How is the `sizeof()` calculated here? Is it the size of the masks themselves, or a header block. (SVE above is clearly a header of some kind)
added a comment to reflect reason behind pac data minimum size


================
Comment at: lldb/test/API/functionalities/postmortem/elf-core/TestLinuxCore.py:451
+        self.assertTrue(target, VALID_TARGET)
+        process = target.LoadCore("linux-aarch64-pac.core")
+
----------------
DavidSpickett wrote:
> Do you need anything special to generate the core file? Might be worth noting in the commit message.
> 
> Though I guess you can just compile a hello world on a Linux system with PAC.
Updated commit message.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99941/new/

https://reviews.llvm.org/D99941