[Lldb-commits] [PATCH] D101153: [lldb][NFC] Specify guidelines for API tests

[David Spickett via Phabricator via lldb-commits]

DavidSpickett added inline comments.


================
Comment at: lldb/docs/resources/test.rst:222
+    ``gmodules`` need to recompile external headers when they encounter
+    test-specific flags (including defines) which can be very expensive.
+
----------------
Does this mean only use the flags you really need, or to put those flags somewhere other than the makefile? (I guess the former since they'd have to be in the makefile for your test to work anyway)

Would be good to make it clear so the reader doesn't think that there's some other place to put compiler flags, which isn't specified.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101153/new/

https://reviews.llvm.org/D101153