[Lldb-commits] [PATCH] D100965: [lldb] Refactor argument group by SourceLocationSpec (NFCI)

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added inline comments.


================
Comment at: lldb/source/API/SBThread.cpp:853
+    if (!location_spec) {
+      sb_error.SetErrorString(
+          llvm::toString(location_spec.takeError()).c_str());
----------------
mib wrote:
> JDevlieghere wrote:
> > Why not `sb_error = location_spec.takeError()`?
> `takeError` returns an `llvm::Error` not a `lldb_private::Status`, and there is no `SBError` constructor for `Status`  so I don't think that's possible.
There is:
```
  explicit Status(llvm::Error error) { *this = std::move(error); }
  const Status &operator=(llvm::Error error);
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100965/new/

https://reviews.llvm.org/D100965